don't use next_start_date for "anytime" courses & programs (#2670)

* don't use next_start_date for "anytime" courses & programs

* add a test

Author: gumaerc

frontends/main/src/page-components/LearningResourceExpanded/InfoSection.test.tsx

@@ -226,6 +226,33 @@ describe("Learning resource info section start date", () => {
     await user.click(showMoreLink)
     expect(runDates.children.length).toBe(totalRuns + 1)
   })
+
+  test("Anytime courses with next_start_date should not replace first date in 'As taught in' section", () => {
+    const course = {
+      ...courses.free.anytime,
+      next_start_date: "2024-03-15T00:00:00Z",
+    }
+
+    renderWithTheme(<InfoSection resource={course} />)
+
+    const section = screen.getByTestId("drawer-info-items")
+
+    within(section).getByText("Starts:")
+    within(section).getByText("Anytime")
+
+    within(section).getByText("As taught in:")
+
+    expect(within(section).queryByText("March 15, 2024")).toBeNull()
+
+    const runDates = within(section).getByTestId("drawer-run-dates")
+    expect(runDates).toBeInTheDocument()
+
+    const firstRun = course.runs?.[0]
+    invariant(firstRun)
+    const firstRunDate = formatRunDate(firstRun, true)
+    invariant(firstRunDate)
+    expect(within(section).getByText(firstRunDate)).toBeInTheDocument()
+  })
 })
 
 describe("Learning resource info section format and location", () => {

frontends/main/src/page-components/LearningResourceExpanded/InfoSection.tsx

@@ -180,21 +180,22 @@ const totalRunsWithDates = (resource: LearningResource) => {
 
 const RunDates: React.FC<{ resource: LearningResource }> = ({ resource }) => {
   const [showingMore, setShowingMore] = useState(false)
+  const anytime = showStartAnytime(resource)
   let sortedDates = resource.runs
     ?.sort((a, b) => {
       if (a?.start_date && b?.start_date) {
         return Date.parse(a.start_date) - Date.parse(b.start_date)
       }
       return 0
     })
-    .map((run) => formatRunDate(run, showStartAnytime(resource)))
+    .map((run) => formatRunDate(run, anytime))
     .filter((date) => date !== null)
 
   const nextStartDate = resource.next_start_date
     ? formatDate(resource.next_start_date, "MMMM DD, YYYY")
     : null
 
-  if (sortedDates && nextStartDate) {
+  if (sortedDates && nextStartDate && !anytime) {
     // Replace the first date with next_start_date
     sortedDates = [nextStartDate, ...sortedDates.slice(1)]
   }