-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email for saved searches #1619
Email for saved searches #1619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion to add a docstring to a function. Also, I noticed that heroku mitopen-rc has an MITOPEN_NOTIFICATION_EMAIL_BACKEND
setting but I think it should be MITOL_NOTIFICATION_EMAIL_BACKEND
instead.
@@ -884,20 +887,24 @@ def _generate_subscription_digest_subject( | |||
prefix = "" if shortform else "MIT Learn: " | |||
|
|||
if sample_course["source_channel_type"] == "saved_search": | |||
if shortform: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would this shortform
be used? Would be helpful to add a dosctring to this function with Args
and Returns
sections
* fixing subject for saved search * changes for formatting search subscription emails * returning channel only if channel subscription type * fixing tests * grouping by individual queries * adding search subscription email sending to celery tasks * reverting iterating through individual queries * removing unused template * fixing resource type display in emails * adding docstring and fixing resource type description * fixing test * fixing test * fixing test
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5578
Description (What does it do?)
This PR tweaks the emails sent out for search subscription emails and also activates the search subscription email as a celery task.
Screenshots (if appropriate):
How can this be tested?
MAILGUN_SENDER_DOMAIN
MAILGUN_KEY
MAILGUN_FROM_EMAIL
NOTIFICATION_EMAIL_BACKEND
docker compose restart celery