Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS/TS partials do not transpile properly #1075

Open
ChristopherChudzicki opened this issue Feb 9, 2023 · 1 comment
Open

JS/TS partials do not transpile properly #1075

ChristopherChudzicki opened this issue Feb 9, 2023 · 1 comment

Comments

@ChristopherChudzicki
Copy link
Contributor

ChristopherChudzicki commented Feb 9, 2023 •
edited
Loading

Steps to Reproduce

  1. Visit https://ocw.mit.edu/courses/3-091-introduction-to-solid-state-chemistry-fall-2018/ or any course in IE11, e.g., via https://live.browserstack.com/dashboard (Or any browser that does not support ES6 arrow functions).
  2. View dev console

Expected Behavior

No syntax errors (E.g., from arrow functions)

Actual Behavior

Syntax errors
@ChristopherChudzicki
Copy link
Contributor Author

We include TS source code as JS in HTML via Hugo's js.Build pipe. But it appears that pipe is not respecting our TSConfig. It would be nice to figure that out.

At the very least, we could specify ES5 as the target environment (see https://gohugo.io/hugo-pipes/js/#options).

@ChristopherChudzicki ChristopherChudzicki mentioned this issue Feb 9, 2023
Open
1 task
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristopherChudzicki