Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course list pages styling inconsistent #1106

Open
ibrahimjaved12 opened this issue Mar 15, 2023 · 2 comments
Open

Course list pages styling inconsistent #1106

ibrahimjaved12 opened this issue Mar 15, 2023 · 2 comments

Comments

@ibrahimjaved12
Copy link
Contributor

ibrahimjaved12 commented Mar 15, 2023

Steps to Reproduce

Open this OCW Style Guide for reference.

  1. Go to this link: https://ocw.mit.edu/course-lists/open-learning-library/
  2. Observe "MIT OPEN LEARNING LIBRARY". It is red, with h1 heading tag but applied styling to match a different font-size. It is also not mobile responsive. This is not according to the styling guideline.
  3. The headings "How MIT Open Learning Library Differs from MIT OpenCourseWare and MITx on edX" are h4 but the font-size, line-height is not according to guidelines.
  4. Same goes for the courses list underneath. Eg. "Structure of Materials" is h4 but with applied styling to look bigger (but not according to guideline) Same as above.
  5. Also: The look and feel on the left also does not seem consistent of course list page and other pages. Compare the left margins: Course List Page About Page Contact Page neither of these are consistent with each other.

Expected Behavior

  • Course list pages should have consistent styling headings according to the OCW Style Guide.
  • The pages should be consistent with each other (including margins)

Actual Behavior

  • The course list page title is not according to the guidelines (it is red instead of black, it is h1 but the font-size, line-height is not right for h1 heading)
  • The other h4 headings are also not according to guidelines (different font-size, line-height)
  • There is too much gap on the left side for desktop screen.

Also:
There may also be a need to update OCW Style Guide for cases like mentioned in this issue, and in here #1105

Related Issues

#1105
#1097

Screenshot or Screencast

image

@HussainTaj-arbisoft
Copy link
Contributor

@pdpinch I had a meeting with @ibrahimjaved12 about this issue. We think we might be working on a redesign for this, can you please confirm if these are the chances we want?

PS: Can you please also add me to the InVision team, I don't have access to the project. My account is [email protected]

@pdpinch
Copy link
Member

pdpinch commented May 23, 2023

I wasn't planning to redesign this page, or the style guide in general, but let's put this on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants