Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home page headings #1136

Open
pdpinch opened this issue May 2, 2023 · 2 comments
Open

Home page headings #1136

pdpinch opened this issue May 2, 2023 · 2 comments
Labels
blocked product:ocw UX

Comments

@pdpinch
Copy link
Member

pdpinch commented May 2, 2023

@ibrahimjaved12 wanted to bring to attention a couple more things to confirm that they're correct or not.
(Refer to screenshots)

  1. Open: https://ocw.mit.edu/
  2. Scroll down at the end to STAY CONNECTED WITH OCW. This and SUBSCRIBE TO THE OCW NEWSLETTER are both div with class name of h5. I suppose they needed to be h5.
  3. The title of a course inside a course card is also div class with class name of h5 to apply h5 styling. I suppose it needed to be h5 too.
  4. The cards under OCW News and OpenCourseWare Stories with overlaying titles, they are a tag and div tag respectively. Maybe they should've been headings?

image

image

image
@pdpinch pdpinch mentioned this issue May 2, 2023
Closed
@pdpinch
Copy link
Member Author

pdpinch commented May 4, 2023

Blocked by https://github.com/mitodl/hq/issues/1388 and https://github.com/mitodl/hq/issues/1385

@pdpinch pdpinch added the blocked label May 4, 2023
@pdpinch pdpinch added the Design label Jun 30, 2023
@HussainTaj-arbisoft
Copy link
Contributor

@pdpinch I'd just like to confirm, is this issue blocked by https://github.com/mitodl/hq/issues/1384 now?

@pdpinch pdpinch added UX and removed Design labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked product:ocw UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdpinch @HussainTaj-arbisoft