-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade hugo-bin-extended to 0.112.7 #1161
Comments
Suggestion: IMO, we should at least open the PR to upgrade
For example, the issue @gumaerc caught in mitodl/ocw-studio#1826 could (in principle) have been caught by a Playwright test in ocw-hugo-themes. It would not actually have been caught unless we do: |
This may be true, as we do run e2e tests with a Also, I think that at least in local dev when it comes to the |
This is not accurate for our e2e tests:
Roughly, the e2e tests:
|
Whoops, I edited my comment above after I realized my error, but for posterity I did make a comment assuming that we don't test with an explicit |
This makes sense to me. Thank you for the suggestion.
@gumaerc could setting Since I was going to work on the publisher image today, I'll follow @ChristopherChudzicki's suggestion and test 0.112.7 on themes first and put up a draft PR. |
This is worth discussing, but I think that behavior is actually desirable. The locally installed node version would be our "canary in the coal mine" so to speak, giving us an indication of issues before they actually become a problem. Either way, if you're seeing weirdness it's not that hard to just change the string temporarily to pin the same version as studio and install that, to see if the behavior changes. |
Background / Purpose
We will upgrade ocw-course-publisher to
0.6
Hugo 0.112.7 (refer to mitodl/ocw-studio#1821), we also need to update hugo-bin-extended to 0.112.7 to match the version in Studio.Description
Update hugo-bin-extended to 0.112.7 to match the version in Studio. This should be done in conjunction with or after mitodl/ocw-studio#1821.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: