Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stories and Testimonials Cards are too dark #939

Open
ChristopherChudzicki opened this issue Oct 31, 2022 · 1 comment
Open

Stories and Testimonials Cards are too dark #939

ChristopherChudzicki opened this issue Oct 31, 2022 · 1 comment

Comments

@ChristopherChudzicki
Copy link
Contributor

ChristopherChudzicki commented Oct 31, 2022 •
edited
Loading

Steps to Reproduce

  1. View https://ocw.mit.edu/ and scroll down to stories or testimonials. The pictures are too dark.

Screenshots

We currently apply a darkening linear gradient to the image in order to provide contrast for the white text at bottom of the image.

Rather than applying the gradient to the whole image, we could instead apply it to the element containing the text, which I did with dev console for some quick screenshots. See below (only did Clinton Blackburn's picture).

Clinton Blackburn's image... screenshot
Current
gradient applied to image		 Screen Shot 2022-10-28 at 4 40 53 PM
No gradient Screen Shot 2022-10-28 at 4 40 42 PM
gradient applied to
element containing text		 Screen Shot 2022-10-28 at 4 45 20 PM
.......................... ⬆️ that one has new filter
@ChristopherChudzicki
Copy link
Contributor Author

@pdpinch Would this UI change be ok with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristopherChudzicki