Use explicit mapping of names #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 82.87% 82.71% -0.17%
==========================================
Files 19 19
Lines 1174 1163 -11
Branches 169 164 -5
==========================================
- Hits 973 962 -11
Misses 177 177
Partials 24 24
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes #241
What's this PR do?
Instead of making a best guess, Doof will see that the name matches exactly with the name in the PR. If yes, the name will be tagged in the slack message, otherwise the name will be used as is without tagging the user.
How should this be manually tested?
N/A