Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many cases of bare except: and except Exception: #1108

Open
moreati opened this issue Aug 26, 2024 · 1 comment
Open

Too many cases of bare except: and except Exception: #1108

moreati opened this issue Aug 26, 2024 · 1 comment
Labels
affects-0.3 Issues related to 0.3.X Mitogen releases bug Code feature that hinders desired execution outcome

Comments

@moreati
Copy link
Member

moreati commented Aug 26, 2024

There are 40ish lines containing a bare except: or overly broad except Exception. They're probably hiding errors that we don't want to hide

➜  mitogen git:(github-actions) ✗ ag "except:|except Exception" mitogen ansible_mitogen -l | sort
ansible_mitogen/mixins.py
ansible_mitogen/module_finder.py
ansible_mitogen/process.py
ansible_mitogen/runner.py
ansible_mitogen/services.py
ansible_mitogen/target.py
mitogen/compat/pkgutil.py
mitogen/core.py
mitogen/debug.py
mitogen/fork.py
mitogen/master.py
mitogen/parent.py
mitogen/profiler.py
mitogen/service.py
mitogen/setns.py
mitogen/unix.py

refs #694

@moreati moreati added bug Code feature that hinders desired execution outcome affects-0.3 Issues related to 0.3.X Mitogen releases labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-0.3 Issues related to 0.3.X Mitogen releases bug Code feature that hinders desired execution outcome
Projects
None yet
Development

No branches or pull requests

2 participants
@moreati and others