Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SV-204392 is implemented incorrectly #200

Open
Amndeep7 opened this issue May 20, 2023 · 0 comments · May be fixed by #201
Open

SV-204392 is implemented incorrectly #200

Amndeep7 opened this issue May 20, 2023 · 0 comments · May be fixed by #201

Comments

@Amndeep7
Copy link

Amndeep7 commented May 20, 2023

At the moment the implementation grabs the packages with incorrect permissions, ownership, or group membership, and then checks to see if it's within an allowlist or not. It then prints any that are not in the allowlist as a single failing test. It also makes the assumption that packages can't have spaces in them.

My read of the requirements say that you need to individually validate the permissions, ownership, and group membership of every file within said packages, and fail out per each of those files. Furthermore, you can only get exceptions for ownership and group membership but not the permissions, which is what the variable name says (the comment associated with the variable is incorrectly looser by allowing exceptions to the verification stuff in general).

@Amndeep7 Amndeep7 linked a pull request May 21, 2023 that will close this issue
3 tasks
@Amndeep7 Amndeep7 linked a pull request May 21, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant