desmell lang flag, implement defaults

mittwald · Aug 27, 2024 · 918d25b · 918d25b
1 parent aced1b9
commit 918d25b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/commands/app/install/magento2.tsx b/src/commands/app/install/magento2.tsx
@@ -23,6 +23,7 @@ export const magento2Installer = new AppInstaller(
     "opensearch-host",
     "opensearch-port",
   ] as const,
+  { "shop-lang": "de_DE" },
 );
 
 export default class InstallMagento2 extends ExecRenderBaseCommand<

diff --git a/src/lib/resources/app/Installer.tsx b/src/lib/resources/app/Installer.tsx
@@ -27,6 +27,7 @@ export class AppInstaller<TFlagName extends AvailableFlagName> {
   public readonly appId: string;
   public readonly appName: string;
   public readonly appSupportedFlags: readonly TFlagName[];
+  public readonly defaultFlagValues: Partial<Record<AvailableFlagName, string>>;
   public readonly description: string;
 
   public mutateFlags?: (
@@ -41,10 +42,12 @@ export class AppInstaller<TFlagName extends AvailableFlagName> {
     appId: string,
     appName: string,
     appSupportedFlags: readonly TFlagName[],
+    defaultFlagValues: Partial<Record<AvailableFlagName, string>> = {},
   ) {
     this.appId = appId;
     this.appName = appName;
     this.appSupportedFlags = appSupportedFlags;
+    this.defaultFlagValues = defaultFlagValues;
     this.description = AppInstaller.makeDescription(appName);
   }
 
@@ -85,6 +88,7 @@ export class AppInstaller<TFlagName extends AvailableFlagName> {
       flags,
       projectId,
       this.appName,
+      this.defaultFlagValues,
     );
 
     const appVersion: AppAppVersion = await normalizeToAppVersionUuid(

diff --git a/src/lib/resources/app/flags.tsx b/src/lib/resources/app/flags.tsx
@@ -229,6 +229,7 @@ export async function autofillFlags(
   flags: Partial<OutputFlags<RelevantFlagInput<AvailableFlagName[]>>>,
   projectId: string,
   appName: string,
+  defaults: Partial<Record<AvailableFlagName, string>>,
 ): Promise<void> {
   const ownUser = await apiClient.user.getOwnAccount();
   assertStatus(ownUser, 200);
@@ -338,12 +339,10 @@ export async function autofillFlags(
 
   // Shop Language Code
   if (necessaryFlags.includes("shop-lang") && !flags["shop-lang"]) {
-    if (appName.toLowerCase().includes("magento")) {
-      flags["shop-lang"] = "de_DE";
-    } else {
-      flags["shop-lang"] = "de-DE";
-    }
-    process.addInfo(<Text>Using default shop language 'de_DE'.</Text>);
+    flags["shop-lang"] = defaults["shop-lang"] ?? "de-DE";
+    process.addInfo(
+      <Text>Using default shop language '{flags["shop-lang"]}'.</Text>,
+    );
   }
 
   // Shop Currency