Add command to install HumHub #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the same exact problem (see here). Also for some reason, the generated readme looks entirely different after a fresh repo clone. |
|
I think the README issue should be resolved with #716; furthermore, the README should now be updated automatically in the PR if its not up-to-date. Apart from the README, would this PR be ready for review? |
|
Yes, the readme was the only blocker for this PR |
martin-helmich
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I deleted the old branch since it was kinda stale and I am still trying to understand Node, yarn and oclif a bit more.
And since the changes are rather trivial I started over.
Sadly the
yarn generate:readmecommand still adds newlines where they dont belong.I tried
still no cigar.
@martin-helmich please advise