Fixed the ArrayOutOfBoundException happening for the north direction

Signed-off-by: jk KPADEY <[email protected]>
mivek · Feb 26, 2021 · e13bf66 · e13bf66
1 parent f398f84
commit e13bf66
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/metarParser-commons/src/main/java/io/github/mivek/utils/Converter.java b/metarParser-commons/src/main/java/io/github/mivek/utils/Converter.java
@@ -36,7 +36,7 @@ public static String degreesToDirection(final String degreesStr) {
             return Messages.getInstance().getString("Converter.VRB");
         }
 
-        return Messages.getInstance().getString("Converter." + DIRECTIONS[(int) ((degrees + 11.5) / 22.5)]);
+        return Messages.getInstance().getString("Converter." + DIRECTIONS[(int) ((degrees + 11.5) / 22.5) % DIRECTIONS.length]);
     }
 
     /**

diff --git a/metarParser-commons/src/test/java/io/github/mivek/utils/DegreesToDirectionTest.java b/metarParser-commons/src/test/java/io/github/mivek/utils/DegreesToDirectionTest.java
@@ -34,6 +34,7 @@ public static Collection<Object[]> data() {
             { "Converter.SW", "230" },
             { "Converter.N", "2" },
             { "Converter.NNW", "345" },
+            { "Converter.N", "350" },
             {"Converter.VRB","anyString"}
         });
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 return Messages.getInstance().getString("Converter.VRB");
             }
-            return Messages.getInstance().getString("Converter." + DIRECTIONS[(int) ((degrees + 11.5) / 22.5)]);
+            return Messages.getInstance().getString("Converter." + DIRECTIONS[(int) ((degrees + 11.5) / 22.5) % DIRECTIONS.length]);
         }
         /**
@@ Expand Down @@