Omit keywords #15
Open
Omit keywords #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use old name
use consistent name
same name
|
Note: I've seen some adblockers or company policies look for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL: certain adblockers (like ublock origin) are fuzzy matching on keywords like
mixpanelin the URL, in addition to maintaining filter lists likeapi.mixpanel.com,cdn.mxpnl.com, etc...the "one click deploy" scripts (for example on google cloud run) will grab the name of the service from the metadata (
app.json) in this repo which ends up as a subdomain for the public URL that gets created... so:spits out a URL like:
https://mixpanel-tracking-proxy-lmozz6xkha-uc.a.run.app/out of the box, this gets blocked (by the more sophisticated adblockers).
while it's not hard to change the name of your service, i think the one-click deploys should aim to work without too much fuss... so this PR just gets rid of the
mixpanelkeywords in the service name for the various one click providers... so we don't end up with an endpoint that gets flagged by some adblockers.