Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Panels computed too early if c.write is used #22

Open
RandalSchwartz opened this issue Jun 15, 2015 · 0 comments
Open

Debug Panels computed too early if c.write is used #22

RandalSchwartz opened this issue Jun 15, 2015 · 0 comments

Comments

@RandalSchwartz
Copy link

It looks like this section of the code:

        my $content = $self->renderer->($vars);
        return sub {
            my $chunk = shift;
            return unless defined $chunk;
            $chunk =~ s!(?=</body>)!$content!i;
            return $chunk;
        };

will freeze the content of the debug panels the first time some streaming content comes back. In our app, we're using c.write to get Time-To-First-Byte down, and therefore the panels are frozen at that time, and don't contain data that would have been accumulated throughout the rendering of the page. Would it be possible to compute $content only when </body> is seen instead, so that the debug panels are computed after the full page render?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant