Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript typings #225

Open
lastmjs opened this issue May 2, 2018 · 3 comments
Open

TypeScript typings #225

lastmjs opened this issue May 2, 2018 · 3 comments

Comments

@lastmjs
Copy link
Contributor

lastmjs commented May 2, 2018

It would be excellent to have typings for this library, especially when working with this library's inheritance.
@miztroh-zz
Copy link
Owner

Happy to review a PR for this :)

@miztroh-zz
Copy link
Owner

miztroh-zz commented May 22, 2018 •
edited
Loading

@lastmjs: If you're looking to tackle this, then you may care to look at the new branch where I'm developing a version of wysiwyg-e based on the new lit-element (based on lit-html) base class discussed at this year's Google IO.

The new version is also utilizing the new Material Web Components.

Once lit-element / lit-html achieve a 1.0 release and the remaining Material Web Components are released, I'll be looking to release this branch as wysiwyg-e 4.0. As such, we should probably target this branch for the development of TypeScript typings. Thanks!

@lastmjs
Copy link
Contributor Author

lastmjs commented May 22, 2018

Sounds good, not sure when I'll get to this as I've had some priority changes with projects, but I'm hoping to get to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miztroh-zz @lastmjs