From 67c60574d7104fb7719ce5c4a45c4d7a06648bc2 Mon Sep 17 00:00:00 2001 From: konstantin Date: Thu, 17 Oct 2024 19:02:55 +0200 Subject: [PATCH 1/4] Set min version of holidays to 0.59 to include 2025-05-08 ("Tag der Befreiung") it's not released yet but will include a fix for https://github.com/vacanza/holidays/issues/2051 will be released on Oct 21st https://github.com/vacanza/holidays/pull/2052#issuecomment-2419908824 --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 1a6b1d0..dd65941 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -50,7 +50,7 @@ classifiers = [ "Programming Language :: Python :: 3.13", ] dependencies = [ - "holidays>=0.16;python_version>='3.8'", + "holidays>=0.59;python_version>='3.8'", "pytz>=2022.7.1", "python-dateutil", ] From 53abe73ce2f103120951ef5133bd565f5a4778a7 Mon Sep 17 00:00:00 2001 From: konstantin Date: Mon, 28 Oct 2024 06:35:57 +0100 Subject: [PATCH 2/4] set minimum python version to 3.9 as suggested in https://github.com/mj0nez/bdew-datetimes/pull/181#issuecomment-2421099671 but why do we set this here at all? doesn't holidays itself define its minimal required python version? --- pyproject.toml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index dd65941..faa698a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -50,7 +50,8 @@ classifiers = [ "Programming Language :: Python :: 3.13", ] dependencies = [ - "holidays>=0.59;python_version>='3.8'", + "holidays>=0.59;python_version>='3.9'", + "pytz>=2022.7.1", "python-dateutil", ] From 60d16eb86b345d21a3b1bdf6283f7f055482ccf3 Mon Sep 17 00:00:00 2001 From: konstantin Date: Mon, 28 Oct 2024 06:38:12 +0100 Subject: [PATCH 3/4] bump holidays in requirements.txt tbh I changed it manually --- requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index f2bbbf7..0b04f08 100644 --- a/requirements.txt +++ b/requirements.txt @@ -4,7 +4,7 @@ # # pip-compile pyproject.toml # -holidays==0.58 ; python_version >= "3.8" +holidays==0.59 ; python_version >= "3.9" # via bdew_datetimes (pyproject.toml) python-dateutil==2.9.0.post0 # via From 51134ae8109cde8b025eeae7fbfbe820229d4f78 Mon Sep 17 00:00:00 2001 From: konstantin Date: Mon, 28 Oct 2024 06:38:41 +0100 Subject: [PATCH 4/4] remove empty line --- pyproject.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index faa698a..33b1883 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -51,7 +51,6 @@ classifiers = [ ] dependencies = [ "holidays>=0.59;python_version>='3.9'", - "pytz>=2022.7.1", "python-dateutil", ]