Compilation clean up warning gnu++11 #71

Thomasb81 · 2024-02-05T01:24:59Z

Clean-up some compilation warning report by g++ 13.2.0

…Wimplicit-fallthrough=]

…c::Rectangle& vpsc::Rectangle::operator=(const vpsc::Rectangle&)' is deprecated [-Wdeprecated-copy]

…er expressions of different signedness: 'int' and 'std::vector<vpsc::Variable*>::size_type' {aka 'long unsigned int'} [-Wsign-compare] cc_nonoverlapconstraints.cpp|204 col 40| warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<vpsc::Variable*>::size_type' {aka 'long unsigned int'} [-Wsign-compare] cc_nonoverlapconstraints.cpp|221 col 40| warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<vpsc::Variable*>::size_type' {aka 'long unsigned int'} [-Wsign-compare] cc_nonoverlapconstraints.cpp|223 col 40| warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<vpsc::Variable*>::size_type' {aka 'long unsigned int'} [-Wsign-compare]

… 2 and 10 bytes into a region of size 9 [-Wformat-overflow=]

…nction [-Wreturn-type] constraints.cpp|116 col 1| warning: control reaches end of non-void function [-Wreturn-type]

… std::out_of_range' by value [-Wcatch-value=] constraints.cpp|327 col 53| warning: catching polymorphic type 'class std::out_of_range' by value [-Wcatch-value=] chains.cpp|432 col 23| warning: catching polymorphic type 'class std::runtime_error' by value [-Wcatch-value=] chains.cpp|441 col 23| warning: catching polymorphic type 'class std::runtime_error' by value [-Wcatch-value=] graphs.cpp|829 col 19| warning: catching polymorphic type 'class std::out_of_range' by value [-Wcatch-value=] topology_graph.cpp|298 col 31| warning: catching polymorphic type 'class std::runtime_error' by value [-Wcatch-value=]

…on [-Wreturn-type] io.cpp|137 col 41| warning: 'gt' may be used uninitialized [-Wmaybe-uninitialized] io.cpp|137 col 41| warning: 'sd' may be used uninitialized [-Wmaybe-uninitialized] io.cpp|137 col 41| warning: 'st' may be used uninitialized [-Wmaybe-uninitialized]

…ed [-Wmaybe-uninitialized]

…n [-Wreturn-type] ortho.cpp|253 col 1| warning: control reaches end of non-void function [-Wreturn-type] ortho.cpp|262 col 1| warning: control reaches end of non-void function [-Wreturn-type]

… in '>= 0' is always true [-Wtype-limits] routing.cpp|150 col 27| warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits]

skieffer

Thanks for this! It looks mostly good, but I do have some nitpicks.

Thanks also for naming the warnings that were being silenced in the commit messages, which made it much easier to review.

cola/libdialect/constraints.cpp

cola/libdialect/io.cpp

cola/libdialect/quadaction.cpp

cola/libdialect/routing.cpp

cola/libdialect/util.h

64bits

Thomasb81 · 2024-02-11T08:28:58Z

There are remaining warning linked to deprecated construction :

adaptagrams/cola/libtopology/topology_graph.h

Line 242 in d00ce59

typedef std::binder1st<

In some project fork:

        typedef std::binder1st<
            std::mem_fun1_t<void, Segment, StraightConstraint*> 
            > TransferStraightConstraint;

has been replaced by

#include <functional>
...
typedef std::function<void(StraightConstraint*)> TransferStraightConstraint;

But that's not enough to clean all related warnings.

Those warning also appear when we try to compile the swig python binding.

skieffer

Thanks for those changes. A couple more, but otherwise looks good.

cola/libdialect/graphs.cpp

cola/libdialect/ortho.cpp

cola/libdialect/routing.cpp

skieffer · 2024-02-12T16:40:23Z

There are remaining warning linked to deprecated construction...

This sounds a fair bit more involved. How about opening a separate issue for it, and then we can get this one merged.

skieffer · 2024-02-12T23:49:54Z

Thanks again!

Thomasb81 added 16 commits February 4, 2024 21:50

rectangle.cpp|401 col 14| warning: this statement may fall through [-…

70e7d05

…Wimplicit-fallthrough=]

connected_components.cpp|54 col 60| warning: implicitly-declared 'vps…

cc9c448

…c::Rectangle& vpsc::Rectangle::operator=(const vpsc::Rectangle&)' is deprecated [-Wdeprecated-copy]

Remove previous code

bcfd6ec

libdialect/util.h|99 col 30| warning: '%2d' directive writing between…

01f1a06

… 2 and 10 bytes into a region of size 9 [-Wformat-overflow=]

Optimization : just what we need

be448d9

constraints.cpp|76 col 1| warning: control reaches end of non-void fu…

76ddec1

…nction [-Wreturn-type] constraints.cpp|116 col 1| warning: control reaches end of non-void function [-Wreturn-type]

Missing one byte for nul terminal caractere

f94e824

Revert code change

a78290a

graphs.cpp|1080 col 24| warning: 'lastStress' may be used uninitializ…

0e14af5

…ed [-Wmaybe-uninitialized]

ortho.cpp|155 col 1| warning: control reaches end of non-void functio…

fea7443

…n [-Wreturn-type] ortho.cpp|253 col 1| warning: control reaches end of non-void function [-Wreturn-type] ortho.cpp|262 col 1| warning: control reaches end of non-void function [-Wreturn-type]

quadaction.cpp|112 col 19| warning: comparison of unsigned expression…

8e1293b

… in '>= 0' is always true [-Wtype-limits] routing.cpp|150 col 27| warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits]

Typo

d748672

Fix return function and unsigned/sign comparaison

b5cc581

skieffer reviewed Feb 11, 2024

View reviewed changes

Thomasb81 added 5 commits February 11, 2024 08:46

Remove unnecessary return in libdialect/constraints.cpp

4a4c649

Add variable initialiszation and remove default assignement

beca71b

Simplify assertion test

9aaf15d

Solve compilation warning according to maintener wish

6759af3

increase the buffer size to support eventually arch where int would be

411de67

64bits

skieffer requested changes Feb 12, 2024

View reviewed changes

Thomasb81 added 3 commits February 12, 2024 22:41

Remove useless return statement

e48c7f4

remove useless return

b950228

remove useless comment

2a423a5

skieffer approved these changes Feb 12, 2024

View reviewed changes

skieffer merged commit 1b6afc5 into mjwybrow:master Feb 12, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compilation clean up warning gnu++11 #71

Compilation clean up warning gnu++11 #71

Thomasb81 commented Feb 5, 2024

skieffer left a comment

Thomasb81 commented Feb 11, 2024 •

edited

Loading

skieffer left a comment

skieffer commented Feb 12, 2024

skieffer commented Feb 12, 2024

Compilation clean up warning gnu++11 #71

Compilation clean up warning gnu++11 #71

Conversation

Thomasb81 commented Feb 5, 2024

skieffer left a comment

Choose a reason for hiding this comment

Thomasb81 commented Feb 11, 2024 • edited Loading

skieffer left a comment

Choose a reason for hiding this comment

skieffer commented Feb 12, 2024

skieffer commented Feb 12, 2024

Thomasb81 commented Feb 11, 2024 •

edited

Loading