Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake-based dev builds don't work (releases are using GNU Make) #48

Closed
ssrlive opened this issue Jan 14, 2020 · 1 comment
Closed

CMake-based dev builds don't work (releases are using GNU Make) #48

ssrlive opened this issue Jan 14, 2020 · 1 comment

Comments

@ssrlive
Copy link
Contributor

ssrlive commented Jan 14, 2020

test it on Windows / Linux / macOS, all the Release buildings are failed.

ssrlive@ss:~/Desktop/gc/build$ cat ../CMakeLists.txt
cmake_minimum_required(VERSION 3.0)
project(gc C)

set(CMAKE_C_STANDARD 11)

include_directories(src)
include_directories(test)

add_executable(gc
        src/gc.h
        src/log.c
        src/log.h
        test/minunit.h
        test/test_gc.c)
ssrlive@ss:~/Desktop/gc/build$ cmake .. -DCMAKE_BUILD_TYPE=Release
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ssrlive/Desktop/gc/build
ssrlive@ss:~/Desktop/gc/build$ make
[100%] Built target gc
ssrlive@ss:~/Desktop/gc/build$ ./gc
---=[ GC tests
Heap allocation referenced from stack should be tagged
Tests run: 5
@mkirchner mkirchner added the wontfix This will not be worked on label Jan 15, 2020
@mkirchner mkirchner changed the title Release build can NOT pass the test. CMake-based dev builds don't work (releases are using GNU Make) Jan 15, 2020
@mkirchner mkirchner removed the wontfix This will not be worked on label Jan 15, 2020
@mkirchner
Copy link
Owner

@ssrlive, thanks for reporting this. As you are aware, gc is not building releases using CMake but currently uses GNU make. There is an open PR (#41, from you, actually) that has the goal to provide a functional CMake configuration and that is currently incomplete.

I am closing this issue and and adding your observations to #41, which is where they belong.s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants