Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighter colors with 0.2.0 #7

Open
FezVrasta opened this issue Oct 16, 2017 · 4 comments
Open

Lighter colors with 0.2.0 #7

FezVrasta opened this issue Oct 16, 2017 · 4 comments

Comments

@FezVrasta
Copy link

Hi, with the 0.2.0, my icons when applied have a lighter color than the original one. (top original, bottom applied)

image

image

Attached you find both icons if you need them for testing purposes.
Archive.zip

@mklement0
Copy link
Owner

That's odd.

I've switched from sips -i to using the NSWorkSpace.setIcon:forFile Cocoa API, so as to support macOS 10.13+ and also bring higher resolutions to earlier versions.

I don't see any options regarding colors there, unfortunately.

@FezVrasta
Copy link
Author

FezVrasta commented Oct 17, 2017

Maybe related to this?
atom/atom#15410

But both my icons look good when opened with preview or applied manually 🤔

@mklement0
Copy link
Owner

@FezVrasta: Thanks for the link - it does sound related, but the fix there was to statically generate a new set of icons, so I'm not aware of any solution yet.

The link mentions color profiles, but the API I use has no parameters for that.

@relikd
Copy link

relikd commented Jan 23, 2020

could it be that a color profile is attached to the image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants