Screenshots from Browser Library in combination with argumentfiles are not linked correctly in the report files

[OkuRobot]

Found in pabot Version 4.0.5

Given the following Testcase file testcases.robot

*** Settings ***
Library     Browser

*** Variables ***
${ARGUMENT}     Default_Value

*** Test Cases ***
Testcase With Screenshot
    Log    Test executed with arguments ${ARGUMENT}
    Open Browser    url=https://pabot.org/
    Take Screenshot    filename=pabot_${ARGUMENT}

and an argumentfile first.args with the following content
--variable ARGUMENT:First

Than start the testrun with the following command
pabot --argumentfile1 first.args --artifactsinsubfolders -d results testcases.robot

This will result in the following result folder structure

Opening the report file the screenshot is not linked correctly

[stlxiii]

As a work around, I did this

• Recursively move all png files under pabot_results to the standard browser/screenshot folder after testing
• Cease using Browser.Take Screenshot as it generates duplicates, instead make your own. something like this:

${timestamp}   Get Current Date  result_format=epoch  
${timestamp}   Evaluate          str(int($timestamp))
${random_str}  Evaluate          ''.join(random.choices(string.ascii_lowercase + string.digits, k=15))

Browser.Take Screenshot  
...    filename=screen-${timestamp}-${random_str}

[rasjani]

Started to use pabot on new project last week and i noticed the same thing. Maybe running rebot on final output.xml to regenerate the html files would help - browser does this on their tasks.py at least ? Dunno, didnt bother. I run

for image in (BASE / "browser" / "screenshot").glob("*.png"):
    new_name = re.sub(r"\d+-","", str(image))
    image.rename(new_name)

at the end of my runner and things good

Also, there was this bug MarketSquare/robotframework-browser#669 and all i got out from that was "you are using the feature incorrectly" but i didnt get "what feature"

PS. Im not using argument file and here's how i call pabot

        python -mpabot.pabot \
        --processes 6 \
        --artifacts json,har,html,webm,png  \
        --artifactsinsubfolders \
        --nostatusrc \
        --outputdir reports/ \
        --exclude noci \
        --loglevel DEBUG \
        -v ENV:${{ inputs.TEST_ENV }} \
        -v IGNORE_HTTPS_ERRORS:True \
        --include ${{ inputs.TEST_ENV }} \
        tests/
        python tools/ghareports.py  reports/output.xml
        python tools/fix_screenshot_links.py  reports/

[vcarnogu]

For me the issue was the space in the screenshot file name.
Using v2.18.0 since there nothing significant in the next releases.

        ${test_name}=  Replace String  ${TEST NAME}  ${SPACE}  -
        ${filename}=   Set Variable  ${test_name}-{index}
        Take Screenshot  filename=${filename}