New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in new image processing #25

Open

matteobaccan opened this issue Aug 31, 2021 · 0 comments

Contributor

matteobaccan commented Aug 31, 2021

Hi

Last commits include my TOC modification and also an interesting feature for add image to PDFs.

I have try to use image inclusion but IMHO there are 2 thing to change

this line

var meddir = '/github/workspace' + media_dir + '/';

after workspace is better add a / like other dirs

new commit use express, but express is not included in the package. For this reason makepdfs give an error when you try to use it

I think you can easily fix these two issue

all the best
Matteo Baccan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment