Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MonadTrace interfaces duplicates (by moving to co-log), get rid of logMsg and format logs as JSON #231

Open
uhbif19 opened this issue Apr 3, 2023 · 0 comments
Assignees

Comments

@uhbif19
Copy link
Contributor

uhbif19 commented Apr 3, 2023

Follow-up for #217

Updated

Now we have two MonadTraces. Using of fundeped one could help to remove logMsg completely, by leveraging structured message embedding.

But it seems like co-log already implement all the same as we trying do. Also some of our utilities seems to not work properly and they probably have more thoughtful types. Also they have solution for concurrent logs (which we have minor bug about).

I dropped all Hydra Traces usage, but if they will be needed again, we can easily support them cuz LogAction is essentially the same.

JSON is better then current formatting with pretty-printing cuz instances could be derived, JSON logs are supported by various tools, and Hydra /Cardano use them too.

@uhbif19 uhbif19 changed the title Make MonadTrace fundeped and get rid of logMsg Fix MonadTrace interfaces duplicates (by moving to co-log), get rid of logMsg and format logs as JSON Apr 21, 2023
@uhbif19 uhbif19 self-assigned this Apr 27, 2023
@uhbif19 uhbif19 removed this from the M7 Testing milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant