Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update inputs using the flake-update Hercules CI effect #13

Open
aciceri opened this issue Jan 17, 2024 · 4 comments
Open

Comments

@aciceri
Copy link
Member

aciceri commented Jan 17, 2024

Not directly part of the milestone but it should easy and useful.
For now I wouldn't enable autoMerge.

@zmrocze
Copy link
Contributor

zmrocze commented Jan 28, 2024

included in #15, not to generate unnecessary merges, this is small change

@zmrocze zmrocze mentioned this issue Jan 28, 2024
1 task
@zmrocze
Copy link
Contributor

zmrocze commented Jan 28, 2024

How to treat node updates?

Firstly, not all master commits in cardano-node pass their CI, so I would rely on releases (maybe we can ask them to create a release branch? because their master is really develop).

Secondly, do we need to support few node versions explicitly? Or is it enough that users can always overwrite cardano-node input. My opinions is that's enough, let's keep using latest mainnet.

@aciceri
Copy link
Member Author

aciceri commented Jan 28, 2024

Firstly, not all master commits in cardano-node pass their CI, so I would rely on releases (maybe we can ask them to create a release branch? because their master is really develop).

Agree 👍

Secondly, do we need to support few node versions explicitly? Or is it enough that users can always overwrite cardano-node input. My opinions is that's enough, let's keep using latest mainnet.

For now I would target one release and manually update it when needed. If we manually specify a release as our input flake-update will not update it obviously.
It would be nice targetting multiple versions but we have enough to do for this milestone.

@zmrocze
Copy link
Contributor

zmrocze commented Feb 3, 2024

IntersectMBO/cardano-node#5661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants