Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Comments #49

Open
beeterry opened this issue Jun 7, 2024 · 4 comments
Open

Deleting Comments #49

beeterry opened this issue Jun 7, 2024 · 4 comments

Comments

@beeterry
Copy link

beeterry commented Jun 7, 2024

This works great. I have this triggered in a build policy, so as changes get pushed to a PR, this gets run again. I see that the code exists to delete comments, but in my case, the existing comments from the prior changes aren't deleted. I would expect the comments prior to the changes would be deleted. Is this a bug in the codebase or do I need to enable some other permission?

@krclarke101
Copy link

Hi there,

Did the review actually create any comments?

I just get this

Start deleting existing comments added by the previous Job ...
Existing comments deleted.
Start reviewing

@beeterry
Copy link
Author

beeterry commented Jun 7, 2024

Yes it creates comments. I struggled with getting the permissions right there too. You need to go to your repository security tab where the user permissions are. Then search for "Project collection build service" and a user should appear. You then have to set the Contribute and Contribute to pull requests to "allow".

@krclarke101
Copy link

Hi, thanks for the info. I added allow to the Contribute but I can't find "Contribute to pull requests" was it in the same place?

@beeterry
Copy link
Author

Yes they are right next to each other. Mine looked as screenshotted in the docs of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants