"Powered By" page for the MLflow website #22
Conversation
Signed-off-by: Daniel Lok <[email protected]>
Signed-off-by: Daniel Lok <[email protected]>
Signed-off-by: Daniel Lok <[email protected]>
Preview for 64ad852
|
website/src/data/companies.json
Outdated
| @@ -0,0 +1,64 @@ | |||
| { | |||
| "ABN AMRO": "https://www.abnamro.com", | |||
There was a problem hiding this comment.
the structure of this file can be modified. for now i kept it simple with `{ <name>: <url> }, but we could also do something like:
{
<name>: {
url: <url>,
src: <path/to/logo.svg>,
// other fields?
},
...
}
There was a problem hiding this comment.
I prefer the name: {url, src} style.
Signed-off-by: Daniel Lok <[email protected]>
Signed-off-by: Daniel Lok <[email protected]>
website/src/pages/powered-by.tsx
Outdated
There was a problem hiding this comment.
Can we create a powered-by directory and changed this file to website/src/pages/powered-by/index.tsx?
|
cc @mahesh-venkatachalam What do you think of the layout and feel of the added page? |
website/src/pages/powered-by.tsx
Outdated
| and contributing to MLflow. To add your organization here, email our | ||
| user list at{" "} | ||
| <a href="https://groups.google.com/g/mlflow-users"> | ||
| [email protected] | ||
| </a> | ||
| ! |
There was a problem hiding this comment.
Can we replace "email our user list at ..." with "open a PR at https://github.com/mlflow/mlflow-website"?
There was a problem hiding this comment.
We can file another PR to add a new logo once this PR is merged, and put that PR as an example like below:
open a PR at https://github.com/mlflow/mlflow-website (example)
^^^^^^^^^
There was a problem hiding this comment.
oh yeah that would be much better haha
There was a problem hiding this comment.
removed MosaicML from this list, and will add it back in a PR later after this lands so we can provide an example
Signed-off-by: Daniel Lok <[email protected]>
Signed-off-by: Daniel Lok <[email protected]>
Signed-off-by: Daniel Lok <[email protected]>
|
The logo are colored when the screen is narrow. Is this intended? 
|
Yup, I did some testing and realized that the hover action doesn't work on mobile, so I just decided to make them colored |
Add a page on the new website to put all the company logos:
Screen.Recording.2024-02-02.at.3.15.11.PM.mov
I'm not super sure what the content should be, let me know if anyone has any better suggestions! I tried to include all of the companies from the old website's logo section, but some of them are now defunct / got acquired / don't have SVG logos. My thought was that if any organization wants their logo on the new site, they can reach out to us and we can ask them to provide an SVG we can use.
The logos are also sorted alphabetically, but let me know if there's any specific order we want!