Projection support #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created with ``` globe=ccrs.Globe(semimajor_axis=6367470,semiminor_axis=6367470) 4:41 ccrs.LambertConformal(central_longitude=proj_inf[‘LoV’]/1e6,standard_parallels=(proj_inf[‘Latin1’]/1e6,proj_inf[‘Latin2’]/1e6), central_latitude=((proj_inf[‘Latin1’]/1e6+proj_inf[‘Latin2’]/1e6))/2 ,false_easting=0, false_northing=0, globe=globe).to_cf() ```
observingClouds
force-pushed
the
projection_support_stage1
branch
3 times, most recently
from
c8d6ed0
to
5946210
Compare
observingClouds
force-pushed
the
projection_support_stage1
branch
from
5946210
to
db737ab
Compare
observingClouds
commented
Nov 14, 2024
Comment on lines
+209
to
+211
| # TODO: generalize the retrieval of x and y coords | ||
| # coords = (dataarrays_by_target[target_output_var][0]['x'], dataarrays_by_target[target_output_var][0]['y']) | ||
| # lon, lat = get_latitude_longitude_from_projection(projection, coords) |
There was a problem hiding this comment.
@ealerskans this would be my current proposal for you on where and how you could generate the lats and lons from x and y.
This is obviously per projection in each dataset and because we only accept one projection for now, you might just skip this step for all following datasets.
There was a problem hiding this comment.
the function is available from from .ops.projection
observingClouds
commented
Nov 14, 2024
SimonKamuk
reviewed
Nov 18, 2024
Co-authored-by: SimonKamuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventually fixes #33
Main changes:
projectionsattribute to dataset input section (seeexample.danra.yaml)projectionssection will acceptcrs_wkt, single-value projection attributes or both, withcrs_wktbeing prioritizedOff-topic-changes (though required for better testing):
flatten-methodQuestions:
grid_mappingattribute, e.g.staticand others which depend on thegrid_indexwhich can map toxandy? Is there a standard for this?