We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: search?q=ben%27s
search?q=ben%27s
if query has an apostrophe in it, this breaks, for example:
query
query => ?q=ben%27s queryRegExp => \?q=ben%27s
// Add the query string, if not already present if (query && !fragment.match(queryRegExp)) { fragment += query; }
This passes the test above and leads to fragment being doubled over, returning:
fragment => search?q=ben's?q=ben%27s
You should decode the query before crafting a regex:
decodeURIComponent(query).replace(escapeRegExp, '\\$&');
The text was updated successfully, but these errors were encountered:
No branches or pull requests
url:
search?q=ben%27s
if
query
has an apostrophe in it, this breaks, for example:This passes the test above and leads to fragment being doubled over, returning:
You should decode the query before crafting a regex:
The text was updated successfully, but these errors were encountered: