Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y_table and c_table transposes? #2

Open
siegelaaron94 opened this issue Sep 1, 2021 · 2 comments
Open

y_table and c_table transposes? #2

siegelaaron94 opened this issue Sep 1, 2021 · 2 comments

Comments

@siegelaaron94
Copy link

How confident are you that the transposes on the y_table and c_table are correct? To me, they don't seem correct, and depending on the quality level you can get the average error between the output and OpenCV's result by not transposing them.

@Embeddave
Copy link

The transpose is there so the linear algebra works out correctly when converting a whole image instead of a single color value [R G B], see:
https://stackoverflow.com/a/46991488/13117946

skimage does the same thing:
https://github.com/scikit-image/scikit-image/blob/215296d0995a6eda0f68418d6e3beabbc2efd8d3/skimage/color/colorconv.py#L647

(I didn't know this, I was worried by the same thing and had to look it up)

@Seeyn
Copy link

Seeyn commented Dec 9, 2022

The program's output is different from OpenCV's. Is there any way to fix it?🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants