Merge branch 'main' into aorsf-min-events

mlr-org · Nov 8, 2024 · 58c4cad · 58c4cad
2 parents 7880bd4 + fef9dd7
commit 58c4cad
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: mlr3extralearners
 Title: Extra Learners For mlr3
-Version: 0.9.0-9000
+Version: 1.0.0
 Authors@R: c(
     person("Raphael", "Sonabend", , "[email protected]", role = "aut",
            comment = c(ORCID = "0000-0001-9225-4654")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # dev
 
+# mlr3extralearners 1.0.0
+
 * Add "Prediction types" doc section for all 30 survival learners + make sure it is consistent #347
 * All survival learners have `crank` as main prediction type (and it is always returned) #331
 * Added minimum working version for all survival learners in `DESCRIPTION` file

diff --git a/R/learner_BART_surv_bart.R b/R/learner_BART_surv_bart.R
@@ -137,9 +137,11 @@ LearnerSurvLearnerSurvBART = R6Class("LearnerSurvLearnerSurvBART",
       times = truth[, 1]
       delta = truth[, 2] # delta => status
 
+      .fun = ifelse(.Platform$OS.type == "windows", BART::surv.bart, BART::mc.surv.bart)
+
       list(
         model = invoke(
-          BART::mc.surv.bart,
+          .fun,
           x.train = x.train,
           times = times,
           delta = delta,

diff --git a/R/learner_mgcv_classif_gam.R b/R/learner_mgcv_classif_gam.R
@@ -1,5 +1,5 @@
 #' @title Classification Generalized Additive Model Learner
-#' @author JazzyPierrot
+#' @author pierrecamilleri
 #' @name mlr_learners_classif.gam
 #'
 #' @description

diff --git a/R/learner_mgcv_regr_gam.R b/R/learner_mgcv_regr_gam.R
@@ -1,5 +1,5 @@
 #' @title Regression Generalized Additive Model Learner
-#' @author JazzyPierrot
+#' @author pierrecamilleri
 #' @name mlr_learners_regr.gam
 #'
 #' @description

diff --git a/man/mlr_learners_classif.gam.Rd b/man/mlr_learners_classif.gam.Rd
diff --git a/man/mlr_learners_regr.gam.Rd b/man/mlr_learners_regr.gam.Rd