add BART survival learner #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebffischer to check/discuss during the workshop? |
sebffischer
reviewed
Aug 21, 2023
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
* will work with latest version of distr6
|
Depends on mlr-org/mlr3proba#330 |
|
@sebffischer we are ready to merge! The RCMD checks fail due to recent updates in aorsf, I guess @bcjaeger you plan to update the learner in another PR? |
|
Sure, I will check it out now. |
sebffischer
requested changes
Oct 16, 2023
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
sebffischer
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I "hacked" some stuff in this Bayesian learner, so some things could be improved. Notes:
BARTusing one of their internal functions. I saved that in theself$stateslot. Maybe there is a better way?self$stateslot for this again. I added an example on how to use the full posterior survival matrix.