Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGINT/Ctrl-C while profiling should gracefully finish #13

Open
mmarchini opened this issue Jul 24, 2020 · 3 comments
Open

SIGINT/Ctrl-C while profiling should gracefully finish #13

mmarchini opened this issue Jul 24, 2020 · 3 comments

Comments

@mmarchini
Copy link
Collaborator

SIGINT/Ctrl-C while profiling should gracefully finish the profiler and write the results to stdout/file. Two SIGINT/Ctrl-C should stop the program.

@RafaelGSS
Copy link
Contributor

Hey! Just to clarify, is it about close the debugger listener after a command right?

@mmarchini
Copy link
Collaborator Author

Yes, it would stop the profiler, capture the data and send to stdout/file (depending on flags). perf has a similar behavior.

@RafaelGSS
Copy link
Contributor

I take a quick look today on this but seems not supported by nodejs as well. Just local close could be done, maybe sent another signal and provide in docs a default handler to client use? (do not sound good for me).

Maybe can be a great feature on nodejs, what do you think?

Ref: nodejs/help#835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants