Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: audit helper packages #11

Open
mmcloughlin opened this issue Jan 31, 2020 · 1 comment
Open

all: audit helper packages #11

mmcloughlin opened this issue Jan 31, 2020 · 1 comment
Labels
cleanup General cleanup and code health low Low priority

Comments

@mmcloughlin
Copy link
Owner

mmcloughlin commented Jan 31, 2020 •
edited
Loading

Review whether helper packages are necessary now addchain has been broken out on its own.

Can prime and polynomial be internal packages?

Related #7
@mmcloughlin mmcloughlin added this to the Initial Release milestone Feb 1, 2020
@mmcloughlin mmcloughlin added the cleanup General cleanup and code health label Feb 1, 2020
mmcloughlin added a commit that referenced this issue May 16, 2020
@mmcloughlin
prime,polynomial: move to internal
35c55d0 
Updates #11
@mmcloughlin
Copy link
Owner Author

All the following are shared with ec3 so there is scope for deduplication at some point.

github.com/mmcloughlin/addchain/internal/polynomial
github.com/mmcloughlin/addchain/internal/prime
github.com/mmcloughlin/addchain/internal/assert
github.com/mmcloughlin/addchain/internal/bigint
github.com/mmcloughlin/addchain/internal/bigints
github.com/mmcloughlin/addchain/internal/cli
github.com/mmcloughlin/addchain/internal/errutil
github.com/mmcloughlin/addchain/internal/print
github.com/mmcloughlin/addchain/internal/test

Not going to worry about it now, since they are hidden under internal.

@mmcloughlin mmcloughlin added the low Low priority label May 16, 2020
@mmcloughlin mmcloughlin removed this from the Initial Release milestone May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup General cleanup and code health low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmcloughlin