Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro animation completely breaks Lighthouse #4698

Open
hschne opened this issue Feb 20, 2024 · 0 comments
Open

Intro animation completely breaks Lighthouse #4698

hschne opened this issue Feb 20, 2024 · 0 comments

Comments

@hschne
Copy link

hschne commented Feb 20, 2024

What happened?

It's common practice to verify the performance of your page using Lighthouse/Google Page Speed Insights. Unfortunately, the report is completely broken with the Minimal Mistakes theme.

minimalmistakes

Expected behavior

It would be nice to have this working. I'm pretty sure that wasn't always the case, and I assume that Google changed something or other 🤷

Steps to reproduce the behavior

You can verify this easily enough with the Minimal Mistakes homepage.

  1. Go to https://pagespeed.web.dev
  2. Enter https://mmistakes.github.io/minimal-mistakes/ there
  3. Wait
  4. Receive a broken performance report.
    Screen Shot 2024-02-20 at 09 25 06

Other

I traced the issue to $intro-animations on main. Disabling the animation fixes the problem.

$global-transition: none;
$intro-transition: none;

@import "minimal-mistakes/skins/{{ site.minimal_mistakes_skin | default: 'default' }}";
@import "minimal-mistakes";

I'm not sure what the best fix there is. Google uses page speed for SEO ranking, so this not working may be fairly impactful. However, I don't know if it warrants disabling animations altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant