Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifold dimension in rmetric computation #92

Open
sjkoelle opened this issue Jul 19, 2018 · 0 comments
Open

Manifold dimension in rmetric computation #92

sjkoelle opened this issue Jul 19, 2018 · 0 comments

Comments

@sjkoelle
Copy link

In the riemann_metric() method, n_dim is used to iterate over embedding dimensions (line 62-65). However, n_dim, when inherited from mdimG through the get_dual_rmetric() method, refers to the manifold dimension. Therefore, I think that iteration over embedding dimensions in metric computation should be done using mdimY and mdimG should be used to select a subset of singular values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant