Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the manifold dim is lower than embedding dim #98

Open
sjkoelle opened this issue Apr 14, 2020 · 0 comments
Open

When the manifold dim is lower than embedding dim #98

sjkoelle opened this issue Apr 14, 2020 · 0 comments

Comments

@sjkoelle
Copy link

I found a couple bugs associated with the embedding dimension being greater than the manifold dimension, basically having to do with truncating the remaining singular values.

  1. compute_G_from_H should be passing the manifold dimension as an argument (looks like its set up to do this but not doing it currently)

  2. In compute_G_from_H (the 'elif mdimG < n_dim:' part) there are undefined variables and so forth. I don't think this has been tested. As is, it won't work for mdimG < ndim_Y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant