Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storing BIDSPath.root attribute as a string instead of Path? #843

Open
sappelhoff opened this issue Jul 14, 2021 · 0 comments
Open

storing BIDSPath.root attribute as a string instead of Path? #843

sappelhoff opened this issue Jul 14, 2021 · 0 comments

Comments

@sappelhoff
Copy link
Member

Came up in #831 (comment)

We had problems across platforms: On POSIX, BIDSPath.root has forward slashes when printed (__str__), on Windows, it has backslashes. That's undesirable for testing, because BIDS wants forward slashes-only, and it's not consistent anyhow.

Richard had the idea to store BIDSPath.root as a string, and only convert it back to Path when needed.

It would be best if we could store it as a POSIX string ... and then upon converting back to Path, on POSIX it would be a POSIX-Path, whereas on Windows it would be a Windows-Path.

We haven't tested it though.

@sappelhoff sappelhoff added this to the 0.9 milestone Jul 14, 2021
@hoechenberger hoechenberger modified the milestones: 0.9, 0.10 Nov 10, 2021
@hoechenberger hoechenberger modified the milestones: 0.10, future Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants