Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ICA Component Labeling GUI Based on MNE-Python API #72

Open
adam2392 opened this issue Jul 18, 2022 · 0 comments
Open

Refactor ICA Component Labeling GUI Based on MNE-Python API #72

adam2392 opened this issue Jul 18, 2022 · 0 comments

Comments

@adam2392
Copy link
Member

We would like to refactor the ICA GUI to use the ICA API provided in MNE-Python. This will rely on the PR to solve the issues raised in: mne-tools/mne-python#9846 (comment)

I'll think about it, for now, I was more inclined towards (1) because it was constrained. Supporting only datasets in BIDS format makes this first version simpler. 

I don't think it's a good idea to have a pop-up GUI to ask the user for a BIDS path, it can be more error-prone and I don't see a reason to save the IC labels in a .tsv sidecar in a BIDS folder if the original data and ICA decomposition are not in the same BIDS folder.

I like option (3) as well, modifying the ICA instance in place makes a lot of sense, and does not entirely make the .tsv redundant as it will also contain the information about who authored the labels (and other information).

Originally posted by @mscheltienne in #66 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant