From 5912f6e5e60cf9e8f34f29d347f5880fd47e85f9 Mon Sep 17 00:00:00 2001 From: Marijn van Vliet Date: Tue, 7 Jan 2025 10:09:30 +0200 Subject: [PATCH 1/3] also show field strength input fields when not plotting density --- mne/viz/evoked_field.py | 73 ++++++++++++++++++++--------------------- 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a/mne/viz/evoked_field.py b/mne/viz/evoked_field.py index 2a93febba4e..c6af9e6fd22 100644 --- a/mne/viz/evoked_field.py +++ b/mne/viz/evoked_field.py @@ -380,45 +380,44 @@ def _configure_dock(self): # Fieldline configuration layout = r._dock_add_group_box("Fieldlines") - if self._show_density: - r._dock_add_label(value="max value", align=True, layout=layout) - - @_auto_weakref - def _callback(vmax, kind, scaling): - self.set_vmax(vmax / scaling, kind=kind) - - for surf_map in self._surf_maps: - if surf_map["map_kind"] == "meg": - scaling = DEFAULTS["scalings"]["grad"] - else: - scaling = DEFAULTS["scalings"]["eeg"] - rng = [0, np.max(np.abs(surf_map["data"])) * scaling] - hlayout = r._dock_add_layout(vertical=False) - - self._widgets[f"vmax_slider_{surf_map['map_kind']}"] = ( - r._dock_add_slider( - name=surf_map["map_kind"].upper(), - value=surf_map["map_vmax"] * scaling, - rng=rng, - callback=partial( - _callback, kind=surf_map["map_kind"], scaling=scaling - ), - double=True, - layout=hlayout, - ) + r._dock_add_label(value="max value", align=True, layout=layout) + + @_auto_weakref + def _callback(vmax, kind, scaling): + self.set_vmax(vmax / scaling, kind=kind) + + for surf_map in self._surf_maps: + if surf_map["map_kind"] == "meg": + scaling = DEFAULTS["scalings"]["grad"] + else: + scaling = DEFAULTS["scalings"]["eeg"] + rng = [0, np.max(np.abs(surf_map["data"])) * scaling] + hlayout = r._dock_add_layout(vertical=False) + + self._widgets[f"vmax_slider_{surf_map['map_kind']}"] = ( + r._dock_add_slider( + name=surf_map["map_kind"].upper(), + value=surf_map["map_vmax"] * scaling, + rng=rng, + callback=partial( + _callback, kind=surf_map["map_kind"], scaling=scaling + ), + double=True, + layout=hlayout, ) - self._widgets[f"vmax_spin_{surf_map['map_kind']}"] = ( - r._dock_add_spin_box( - name="", - value=surf_map["map_vmax"] * scaling, - rng=rng, - callback=partial( - _callback, kind=surf_map["map_kind"], scaling=scaling - ), - layout=hlayout, - ) + ) + self._widgets[f"vmax_spin_{surf_map['map_kind']}"] = ( + r._dock_add_spin_box( + name="", + value=surf_map["map_vmax"] * scaling, + rng=rng, + callback=partial( + _callback, kind=surf_map["map_kind"], scaling=scaling + ), + layout=hlayout, ) - r._layout_add_widget(layout, hlayout) + ) + r._layout_add_widget(layout, hlayout) hlayout = r._dock_add_layout(vertical=False) r._dock_add_label( From c56add10a868f9eee56b8e41bd7466dfd397f2f6 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 7 Jan 2025 08:18:31 +0000 Subject: [PATCH 2/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- mne/viz/evoked_field.py | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/mne/viz/evoked_field.py b/mne/viz/evoked_field.py index c6af9e6fd22..cf5a9996216 100644 --- a/mne/viz/evoked_field.py +++ b/mne/viz/evoked_field.py @@ -394,28 +394,20 @@ def _callback(vmax, kind, scaling): rng = [0, np.max(np.abs(surf_map["data"])) * scaling] hlayout = r._dock_add_layout(vertical=False) - self._widgets[f"vmax_slider_{surf_map['map_kind']}"] = ( - r._dock_add_slider( - name=surf_map["map_kind"].upper(), - value=surf_map["map_vmax"] * scaling, - rng=rng, - callback=partial( - _callback, kind=surf_map["map_kind"], scaling=scaling - ), - double=True, - layout=hlayout, - ) + self._widgets[f"vmax_slider_{surf_map['map_kind']}"] = r._dock_add_slider( + name=surf_map["map_kind"].upper(), + value=surf_map["map_vmax"] * scaling, + rng=rng, + callback=partial(_callback, kind=surf_map["map_kind"], scaling=scaling), + double=True, + layout=hlayout, ) - self._widgets[f"vmax_spin_{surf_map['map_kind']}"] = ( - r._dock_add_spin_box( - name="", - value=surf_map["map_vmax"] * scaling, - rng=rng, - callback=partial( - _callback, kind=surf_map["map_kind"], scaling=scaling - ), - layout=hlayout, - ) + self._widgets[f"vmax_spin_{surf_map['map_kind']}"] = r._dock_add_spin_box( + name="", + value=surf_map["map_vmax"] * scaling, + rng=rng, + callback=partial(_callback, kind=surf_map["map_kind"], scaling=scaling), + layout=hlayout, ) r._layout_add_widget(layout, hlayout) From 8811358c70f4a7396878f4420711b203b21f39d3 Mon Sep 17 00:00:00 2001 From: Marijn van Vliet Date: Wed, 8 Jan 2025 11:44:11 +0200 Subject: [PATCH 3/3] add changelog --- doc/changes/devel/13048.bugfix.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changes/devel/13048.bugfix.rst diff --git a/doc/changes/devel/13048.bugfix.rst b/doc/changes/devel/13048.bugfix.rst new file mode 100644 index 00000000000..8f0fe46f3c7 --- /dev/null +++ b/doc/changes/devel/13048.bugfix.rst @@ -0,0 +1 @@ +Fix input boxes for the max value not showing when plotting fieldlines with :func:`~mne.viz.plot_evoked_field` when ``show_density=False``, by `Marijn van Vliet`_.