Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.7 introduces requirement that global to be defined #80

Open
thomasballinger opened this issue Dec 23, 2024 · 1 comment
Open

1.7.7 introduces requirement that global to be defined #80

thomasballinger opened this issue Dec 23, 2024 · 1 comment

Comments

@thomasballinger
Copy link

As of 1.7.7 abortcontroller-polyfill requires global or self to be defined to run

import {
  AbortController,
  AbortSignal,
} from "abortcontroller-polyfill/dist/abortcontroller";

Is this intentional, would you accept a PR to change this?

global isn't defined in the WinterCG runtime spec, and Convex's JS runtime which attempts to follow it doesn't have it defined.

@thomasballinger thomasballinger changed the title Requires global to be defined 1.7.7 introduces requirement that global to be defined Dec 23, 2024
@mo
Copy link
Owner

mo commented Dec 24, 2024

@thomasballinger PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants