Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some new images #97

Open
tischi opened this issue Dec 1, 2023 · 2 comments
Open

adding some new images #97

tischi opened this issue Dec 1, 2023 · 2 comments
Labels
question Further information is requested

Comments

@tischi
Copy link
Contributor

tischi commented Dec 1, 2023

@constantinpape

I would like to add some new images.

I guess I would need to create a new version for this, right?!

I guess this should be a major version bump? Or is this only if there is a new primary data type?

The point here is that we will sequentially add more and more images, I don't think we should always increase the major version, should we?

@tischi tischi added the question Further information is requested label Dec 1, 2023
@constantinpape
Copy link
Contributor

The version logic was the following:

  • Major version bump when adding a completely new data type that would add new registrations or so (e.g. x-ray atlas)
  • Minor version bump when updating the cell segmentation (which involves several other changes to derived features), or any other changes that change derived data like morphology features.
  • Patch version bump when just adding new images that don't change any other derived data.

So if we stick to the scheme you would need to to bump the patch version. But from my end it would be fine to just add these to the current version instead; as long as none of the current data is removed or otherwise changed.

@constantinpape
Copy link
Contributor

The script https://github.com/mobie/platybrowser-project/blob/main/update_patch.py is there for bumping patch versions, but it is outdated because it's not compatible with the structure of the project that was updated to the mobie layout.
So if you wanted to bump the patch version the script would need to be brought up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants