You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe it makes sense to change the transaction builder api (in a separate pr)?
My thinking is that since this API is always used by the claimer of an SCI, wouldn't it make sense that they always specify how much they want to get? I think they'll always start with that so they'll end up doing this exact subtraction every time this is used.
There are two things I want to change about the transaction builder APIs around SCIs:
Instead of passing the "partial fill change value", instead pass this "partial fill value" which is intuitively what the user is trying to take from the swap, and let the supporting code calculate the change outputs under the hood.
Instead of calling it "add_presigned_input" and "add_presigned_partial_fill_input", just call it "add_signed_contingent_input" and "add_partial_fill_signed_contingent_input". I don't know why I introduced a new term for this, it's needlessly confusing and I should have tried to be consistent.
The text was updated successfully, but these errors were encountered:
Originally posted by @eranrund in #3214 (comment)
There are two things I want to change about the transaction builder APIs around SCIs:
The text was updated successfully, but these errors were encountered: