New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transition_times for corotating frame? #97

Open

vijayvarma392 opened this issue Aug 27, 2024 · 0 comments

Contributor

vijayvarma392 commented Aug 27, 2024

There is an option to use transition_times for corpecessing frame to avoid ringdown issues:

scri/scri/rotations.py

Line 27 in 544f481

transition_times : 2-tuple or None [defaults to None]

Should we be worried about the same thing for corotating frame? I think no, but just want to check.

In any case, we should have transition_times in the sxs version of to_coprecessing_frame as well: https://github.com/sxs-collaboration/sxs/blob/main/sxs/waveforms/waveform_modes.py#L1178. Didn't want to raise two issues, so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment