Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingering issues in large-example-chapter-2.ipynb #11

Open
9 tasks
alessandrozocca opened this issue Mar 29, 2022 · 0 comments
Open
9 tasks

Lingering issues in large-example-chapter-2.ipynb #11

alessandrozocca opened this issue Mar 29, 2022 · 0 comments
Assignees

Comments

@alessandrozocca
Copy link
Collaborator

alessandrozocca commented Mar 29, 2022

Lingering issues in large-example-chapter-2.ipynb:

  • new name for the file? Maybe "Multistage microchip production"?
  • check preamble
  • code (and Pyomo model) are scattered in too many cells, probably should be consolidated in fewer?same for the markdown cells?
  • code not aligned with Pyomo style guide, please refactor/rewrite it
  • check data import (can it be streamlined even more?)
  • missing description and intuition throughout the file? Plenty of accompanying text (it's in the book, section 2.5)
  • missing full mathematical formulation of the optimization problem (it's in the book, section 2.5)
  • Python/Pyomo variables should reflect those in the mathematical (e.g., x,y instead of buy, stock)
  • Remove/update section title "NOTE: The functions below follow closely the naming in Overleaf"
@alessandrozocca alessandrozocca assigned gromicho and unassigned gromicho Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants