Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingering issues in mad-obtaining-historical-stock-prices.ipynb #12

Open
2 tasks done
alessandrozocca opened this issue Mar 29, 2022 · 3 comments
Open
2 tasks done

Comments

@alessandrozocca
Copy link
Collaborator

alessandrozocca commented Mar 29, 2022

Lingering issues in mad-obtaining-historical-stock-prices.ipynb:

  • is the folder/file creation suitable for the colab setting?
  • are all the import command necessary or the standard preamble would work?
@jckantor
Copy link
Collaborator

I just did some testing on Colab to make sure things are working. It turns out their version of pandas_datareader is out of date, so I added a cell to test for the module, and do an install, upgrade, and/or kernal restart as needed. This did require a fix, so good catch!

@jckantor jckantor reopened this Mar 31, 2022
@jckantor
Copy link
Collaborator

Alessandro ... after more testing on Google Colab, it's clear that getting the data files to persist and be accessible for the portfolio optimization notebook was getting too complex. So I've moved the download code back into the portfolio optimization notebook and will delete this one. A better solution would be to create a module to do the downloading and install that in the tools folder, but that will have to wait for some free time.

@alessandrozocca
Copy link
Collaborator Author

Sounds a good compromise for the time being. I'm leaving this open for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants