Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing dependency to styled-components #7

Open
TomiS opened this issue Jan 16, 2019 · 1 comment
Open

Consider removing dependency to styled-components #7

TomiS opened this issue Jan 16, 2019 · 1 comment

Comments

@TomiS
Copy link

TomiS commented Jan 16, 2019

While styled-components is great, I would like to argue that library like this would be much better off just by manipulating inline styles directly.

Reasoning:

  • There are many css-in-js libs and styled-components is just one of them. The majority of the potential user base cannot use this library because of this dependency. Basically just people who already use styled-components are willing to accept this as dependency.
  • Styled-components seems to add quite little value in this context as you basically just need to manipulate the size and shape of the object (as far as I understand). No reason why this couldn't be done inline.

Of course I can always fork and remove the dependency for myself, but I just wanted to put this here in case this was not very intentional choice.

ps. Otherwise the lib seems really nice and it solves exactly the issue I'm facing right now.

@stwilz
Copy link

stwilz commented Jan 23, 2019

Yeah great library. Super lightweight and flexible!

I agree, the reliance on styled-components doesn't provide much to the library verse the size of the package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants