Cannot unload mod-monitor

[riban-bw]

Usint jack_load mod-host creates a jack client called mod-monitor and automatically connects its audio outputs to system playback ports. When jack_unload mod-host is run, the mod-monitor client remains active and connected. There seems no way to unload mod-monitor client.

Running on arm-32 OS (Debian based) on Raspberry Pi 4 (aarch64) using mod-host version: v0.10.6-532-g0d1cb54.

[falkTX]

mod-host as internal client is not meant to be unloaded, I do not expect that to really work tbqh

[riban-bw]

But surely if jack_load and jack_unload can load and unload internal clients then the internal clients should in fact load and unload? I am not too familiar with the behaviour of internal clients. Is it technically challenging to remove the client when it is unloaded?

[falkTX]

the client that remains is not mod-host, but mod-monitor. so you might be able to "jack_unload mod-monitor", not sure.
mod-host is surely not being nice and leave some stuff behind on cleanup. PRs welcome :)

[riban-bw]

I tried unloading mod-monitor but it fails - probably because it wasn't manually loaded. I will try to find time to investigate but...

[falkTX]

the code for this is in src/effects.c, there is a effects_init and effects_destroy(was it cleanup?), the monitor is loaded in the init but I guess issue is that it is not destroyed on the cleanup side
monitor client code is in its own subfolder.