You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
When the Max quantity option on an item is left blank, in-game the item's maxQuantity property is null.
This leads to the matchingItem._stats.maxQuantity - matchingItem._stats.quantity > 0 condition never passing because null is 0, and items of infinite max quantity will never stack. Either the editor could be reworked to save blank number inputs as Infinity, or line 991 of Unit.js can be changed to check if maxQuantity is null.
When the
![Infinite quantity item in editor](https://camo.githubusercontent.com/31339dd9655ab016a152e45805b866c4197c922447f692a134677e97f95506bb/68747470733a2f2f63646e2e646973636f72646170702e636f6d2f6174746163686d656e74732f3935313930363035333631343837303534382f3935313930383834353230393430373535382f756e6b6e6f776e2e706e67)
![Infinite item's properties](https://camo.githubusercontent.com/8a578c889974a85de0feec67277da1484c6d1e169489b5b3ea469968df5ff953/68747470733a2f2f63646e2e646973636f72646170702e636f6d2f6174746163686d656e74732f3935313930363035333631343837303534382f3935313930383930363435303432333831382f756e6b6e6f776e2e706e67)
Max quantity
option on an item is left blank, in-game the item'smaxQuantity
property isnull
.This leads to the
matchingItem._stats.maxQuantity - matchingItem._stats.quantity > 0
condition never passing because null is 0, and items of infinite max quantity will never stack. Either the editor could be reworked to save blank number inputs as Infinity, or line 991 of Unit.js can be changed to check if maxQuantity is null.taro/src/gameClasses/Unit.js
Line 991 in 08f2f27
The text was updated successfully, but these errors were encountered: