-
Notifications
You must be signed in to change notification settings - Fork 944
fix: set user specified scope in DCR #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @stdevi It would be helpful if you could provide before and after screenshots showing the affected parts of the OAuth debugger when running both Quick and Guided Flows, well as the network tab when running without the OAuth debugger and just using the Connect button. |
|
@cliffhall sure, there are screenshots. Guided FlowsBeforeScope is not included in the client registration request:
Scope is not included in the authorisation URL:
AfterScope is included in the client registration request:
Scope is included in the authorisation URL:
Quick FlowsBeforeScope is not included in the authorisation URL:
After
Running without the OAuth debuggerBefore
After
|
|
@stdevi Thanks for the follow up. However, those last two screenshots (of just using the connect button) look the same. They don't reveal whether the scope was sent or not. We need to see the headers. If you open the network tab on the right instead of the bottom, we'll be able to see all the headers and you can point out the before and after showing that scope was sent.
|
|
@cliffhall But "scope" parameter is not required in the Access Token Request https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.3 |
@stdevi It was just an example to show you how to display all the headers and request data. |
|
@cliffhall but do we expect to see the "scope" header in the request to |
It should be in the authorization URL as well as the returned access token. You have to select it in the network tab to see the details. |
| PREREGISTERED_CLIENT_INFORMATION: "mcp_preregistered_client_information", | ||
| SERVER_METADATA: "mcp_server_metadata", | ||
| AUTH_DEBUGGER_STATE: "mcp_auth_debugger_state", | ||
| SCOPE: "mcp_scope", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this constant being used? I don't see it in any of the changes.















Set user specified scope for dynamically registered client and authorization code retrieval.
Motivation and Context
Currently user specified scopes are ignored.
See #863.
How Has This Been Tested?
Tested with Linear MCP.
Breaking Changes
No breaking changes.
Types of changes
Checklist