Skip to content

Commit 05003c5

Browse files
authored
Bump Go to 1.25 (#456)
<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following PR: * Bumps Go to the latest stable version * Moves away from setting the Go version as an env var in favour of reading it automatically from the go.mod file (better consistency) Closes: #447 ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> Locally ## Breaking Changes <!-- Will users need to update their code or configurations? --> No ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> --------- Signed-off-by: Radoslav Dimitrov <[email protected]>
1 parent bec92b8 commit 05003c5

File tree

5 files changed

+7
-11
lines changed

5 files changed

+7
-11
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
pull_request:
77
branches: [ main ]
88

9-
env:
10-
GO_VERSION: '1.24.x'
11-
129
jobs:
1310
# Build, Lint, and Validate
1411
build-lint-validate:
@@ -21,7 +18,7 @@ jobs:
2118
- name: Set up Go
2219
uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 #v5
2320
with:
24-
go-version: ${{ env.GO_VERSION }}
21+
go-version-file: 'go.mod'
2522

2623
- name: Cache Go modules
2724
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 #v4
@@ -65,7 +62,7 @@ jobs:
6562
- name: Set up Go
6663
uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 #v5
6764
with:
68-
go-version: ${{ env.GO_VERSION }}
65+
go-version-file: 'go.mod'
6966

7067
- name: Cache Go modules
7168
uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 #v4

.github/workflows/deploy.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ on:
77

88
env:
99
PULUMI_VERSION: "3.188.0"
10-
GO_VERSION: "1.24.6"
1110

1211
jobs:
1312
docker-push:
@@ -66,7 +65,7 @@ jobs:
6665
- name: Setup Go
6766
uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 #v5
6867
with:
69-
go-version: ${{ env.GO_VERSION }}
68+
go-version-file: 'go.mod'
7069

7170
- name: Setup Pulumi
7271
uses: pulumi/actions@cc7494be991dba0978f7ffafaf995b0449a0998e #v6
@@ -105,7 +104,7 @@ jobs:
105104
- name: Setup Go
106105
uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 #v5
107106
with:
108-
go-version: ${{ env.GO_VERSION }}
107+
go-version-file: 'go.mod'
109108

110109
- name: Setup Pulumi
111110
uses: pulumi/actions@cc7494be991dba0978f7ffafaf995b0449a0998e #v6

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Go
2222
uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 #v5
2323
with:
24-
go-version: '1.24.x'
24+
go-version-file: 'go.mod'
2525

2626
- name: Install cosign
2727
uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 #v3

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.24-alpine AS builder
1+
FROM golang:1.25-alpine AS builder
22
WORKDIR /app
33

44
# Copy go mod files first and download dependencies

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/modelcontextprotocol/registry
22

3-
go 1.24.0
3+
go 1.25
44

55
require (
66
github.com/caarlos0/env/v11 v11.3.1

0 commit comments

Comments
 (0)